Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conifugration for implicit hyphon characters between words #84

Merged
merged 4 commits into from Aug 21, 2020

Conversation

rolandmueller
Copy link
Contributor

Add a new Configuration implicit_hyphon (default false) for automatically adding hyphon characters - to the rules.
Enabling implicit_hyphon is disabling implicit_punct.
Rationale: implicit_punct is often to much inclusive. The implicit_punct has the hyphon token included, but it is adding (at least in my use case) unwanted tokens (like parentheses) to the matches, especially for more complex rules. So implicit_hyphon is a little bit more strict than implicit_punct.

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #84 into master will increase coverage by 0.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   92.61%   93.36%   +0.75%     
==========================================
  Files          12       12              
  Lines         636      648      +12     
  Branches      108      112       +4     
==========================================
+ Hits          589      605      +16     
+ Misses         32       30       -2     
+ Partials       15       13       -2     
Impacted Files Coverage Δ
rita/config.py 91.04% <ø> (ø)
rita/preprocess.py 100.00% <100.00%> (+0.75%) ⬆️
rita/engine/translate_standalone.py 90.10% <0.00%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279999c...45162b9. Read the comment docs.

@zaibacu zaibacu merged commit 65cfb52 into zaibacu:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants