-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inheritFromParent -> inherit' #12
Comments
Same as my comment here I am trying to avoid apostrophe in naming. |
Replying to the above as well as your comment in that issue: I'm not an F# beginner, but when I was, I didn't see any problem with |
(For completeness: Another alternative is to use double backticks, |
Just want to note that I consistently append
IMHO it looks great in usage, too. :) I suggest doing the same in Feliz, but it's ultimately your call, of course. (And I'm always open to hearing better ways of doing things in Feliz.MaterialUI) |
I agree it makes sense in Material UI context but not really in this base library because of how uncommon it is used and it is here the only one (I think along with I will leave this issue open for a while, maybe someone can enlighten our subjectiveness :) |
Forgot to mention in #42 but I'd just like to be open about the fact that I added one such apostrophe name ( Lines 871 to 885 in 0615e78
|
Thanks for sharing, I didn't see it there but (just as you said) I find it hard to come up with my own versions of names: |
Also, feel free to close this issue if you feel the final decision has been made on |
Last comments on
As for Found a serious issue with this decision? Please open a new issue and let us discuss it 😄 |
Shouldn't it be |
Sorry I wrote incorrectly here but added the right one (with single |
Just pointing out that underscore is also an option to consider, either trailing or leading (e.g. I am not suggesting it for this issue. Decision to use word suffixes is perfectly fine. Just felt like an overlooked option to add to the discussion in case it helps any other onlookers. |
Yep, though prefixing with underscore in F# usually means that it's an unused value (prefixing with underscore suppresses unused warnings). |
Since
inherit
is a reserved keyword, what about simply adding an apostrophe (inherit'
) instead of coming up with another name (inheritFromParent
)?The text was updated successfully, but these errors were encountered: