Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fable.React? (E.g. support for SSR) #31

Closed
cmeeren opened this issue Aug 25, 2019 · 2 comments
Closed

Use Fable.React? (E.g. support for SSR) #31

cmeeren opened this issue Aug 25, 2019 · 2 comments

Comments

@cmeeren
Copy link
Contributor

cmeeren commented Aug 25, 2019

I notice that Fable.React has special handling of server-side rendering, e.g.

https://github.com/fable-compiler/fable-react/blob/fa43005e82490945e2a59beedf86054ae1e929a3/src/Fable.React.Helpers.fs#L336-L342

Since Feliz does not directly use Fable.React for creating components but instead imports stuff itself, it might seem that any features found in Fable.React is not available in Feliz.

Should Feliz delegate component creation (and any other relevant functionality that might come up) to Fable.React in order to take advantage of the specifics of the Fable.React implementation?

@Zaid-Ajaj
Copy link
Owner

I think the SSR implementation of Fable.React is one big mess both for applications and library maintainers with the use of compiler directives. There are no plans of supporting SSR the way Fable.React does for now. I believe there should be better ways for supporting it but SSR in Feliz is low-priority now

@cmeeren
Copy link
Contributor Author

cmeeren commented Aug 28, 2019

Gotcha, feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants