Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feliz.Template v4.3.0 doesn't contain any tests #566

Closed
EverybodyKurts opened this issue Mar 12, 2023 · 3 comments
Closed

Feliz.Template v4.3.0 doesn't contain any tests #566

EverybodyKurts opened this issue Mar 12, 2023 · 3 comments

Comments

@EverybodyKurts
Copy link

EverybodyKurts commented Mar 12, 2023

When initiating a new project with Feliz.Template v4.3.0, the readme includes a section for testing the app:


Tests

The template includes a test project that ready to go which you can either run in the browser in watch mode or run in the console using node.js and mocha. To run the tests in watch mode:

npm run test:live

This command starts a development server for the test application and makes it available at http://localhost:8085.


However, no tests directory or project is included with the template and there is no configuration specified for the tests object in package.json.

Would it make sense to include the test project form the previous version with the necessary updates?

@Zaid-Ajaj
Copy link
Owner

When initiating a new project with Feliz.Template v4.3.0, the readme includes a section for testing the app: [...]

Hi @EverybodyKurts this piece from the README must be leftover from the last template.

Would it make sense to include the test project form the previous version with the necessary updates?

I realized that maintaining the template including all bells and whistles is a lot of work and takes a lot longer to improve.

The alternative is that I've documented in detail how to add a test project from a Fable project in Fable.Mocha which is up to date and should be fairly easy to add to your project (whether using Feliz or not)

@kurt-mueller-osumc
Copy link

kurt-mueller-osumc commented Mar 13, 2023

Hey @Zaid-Ajaj, I can use the tests from Fable.Mocha. My only question is does it matter if the Fable.Mocha repo is using webpack while the new Feliz.Template is using vite?

@MangelMaxime
Copy link
Contributor

@kurt-mueller-osumc In theory, no it doesn't matter.

For things like that, it is best to search how it is done in JavaScript to see if this is doable. Anything done in JavaScript should be doable with Fable and looking for help in JavaScript gives you access to a broader base of knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants