Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way images are listed #66

Closed
lpatiny opened this issue Aug 25, 2023 · 2 comments · Fixed by #91
Closed

Change the way images are listed #66

lpatiny opened this issue Aug 25, 2023 · 2 comments · Fixed by #91
Assignees

Comments

@lpatiny
Copy link
Contributor

lpatiny commented Aug 25, 2023

Currently the opened images are listed on the top

image

It makes it impossible to display meta information about a list of images and have many images selected.

We would prefer the images are listed like in NMRium in a specific panel on the right:

image

What should be done:

  • Create this new panel
  • Remove the tabs
  • When loading a new image switch to this new image
  • Remove the 'old' way to remove an image

image

@stropitek
Copy link
Contributor

stropitek commented Aug 28, 2023

If we do not support multiple images being shown at the same time, I don't see why the selected lines need to have an effect on the canvas.

For me we can have separate selectors:

  • Displayed image -> the image that is shown in the canvas. There is always one selected except when there are no images. Highlighted in the table with a background color.
  • Checkboxes for bulk actions -> I select N images and click delete in the toolbar

If having multiple images at the same time on the canvas is a feature we need at some point, it's probably going to require a separate panel to configure those "layers".

@lpatiny
Copy link
Contributor Author

lpatiny commented Sep 7, 2023

Multiple selection will be done in another issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants