-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag / drop IR also creates IV ???? #222
Comments
Because it is an "IV" it comes from the biologic-parser, I commented it out from this line and the problem disappears. I think this could actually be an error in the parser rather than the Loader (I am not sure yet):
It may return a result even when it does not parse anything, something like this:
Maybe we shouldn't load it yet? I am not sure so I didn't PR anything. |
Ok thanks for the analysis. I think you could fix the parser so that if there is nothing the array is empty. We can quickly make a release of the biologic parser to fix this issue. |
I think this issue was closed at biologic-parser, but we may need to update the dependencies. This one is closed as well with the new biologic, #246. @lpatiny |
Fixed |
There is a bug somewhere because if you simply drag / drop a single ir spectrum the IV tab is also created.
ir.jdx.zip
The text was updated successfully, but these errors were encountered: