Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag / drop IR also creates IV ???? #222

Closed
lpatiny opened this issue Sep 22, 2022 · 4 comments
Closed

Drag / drop IR also creates IV ???? #222

lpatiny opened this issue Sep 22, 2022 · 4 comments

Comments

@lpatiny
Copy link
Contributor

lpatiny commented Sep 22, 2022

There is a bug somewhere because if you simply drag / drop a single ir spectrum the IV tab is also created.

ir.jdx.zip

image

@ghost
Copy link

ghost commented Sep 25, 2022

Because it is an "IV" it comes from the biologic-parser, I commented it out from this line and the problem disappears.

I think this could actually be an error in the parser rather than the Loader (I am not sure yet):

export async function convert(fileList: PartialFileList): Promise<BioLogic[]> {
  const dirs = groupFiles(fileList);
  let results: BioLogic[] = [];

  /* can not use `forEach` and pass `async` functions */
  for (const dir of dirs) {
    let result: BioLogic = {};
    result.dir = dir.key;

It may return a result even when it does not parse anything, something like this:

[{dir:"..."}, {dir:"..."}]

Maybe we shouldn't load it yet? I am not sure so I didn't PR anything.

@lpatiny
Copy link
Contributor Author

lpatiny commented Sep 25, 2022

Ok thanks for the analysis. I think you could fix the parser so that if there is nothing the array is empty. We can quickly make a release of the biologic parser to fix this issue.

@ghost
Copy link

ghost commented Oct 6, 2022

I think this issue was closed at biologic-parser, but we may need to update the dependencies.

This one is closed as well with the new biologic, #246. @lpatiny

@stropitek stropitek self-assigned this Oct 9, 2022
@stropitek stropitek removed their assignment Nov 9, 2022
@targos
Copy link
Member

targos commented Nov 10, 2022

Fixed

@targos targos closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants