feat: tooltip help content #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying react-science with
|
| Latest commit: |
b50e966
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://025da8a0.react-science.pages.dev |
| Branch Preview URL: | https://tooltip-template.react-science.pages.dev |
|
I don't understand the name. Why "Template" ? |
It is not easy to get a good name for the component, I use |
stropitek
reviewed
Apr 8, 2024
There was a problem hiding this comment.
I'd describe the component as "a component to display - within a tooltip - in context help / documentation for an action in the application"
Base on that I can come up with this name:
TooltipHelpContent
Content in the name is important to help make the difference with just Tooltip which refers to a component handling both the target and the content.
stropitek
approved these changes
Apr 8, 2024
stropitek
reviewed
Apr 8, 2024
hamed-musallam
force-pushed
the
tooltip-template
branch
from
ee92ba7
to
b50e966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.