Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sticky table header option #729

Merged
merged 4 commits into from
May 28, 2024
Merged

feat: add sticky table header option #729

merged 4 commits into from
May 28, 2024
+22 −5

Conversation

moonayyur
Copy link
Contributor

closes #728

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 24, 2024 •
edited

Deploying react-science with  Cloudflare Pages  Cloudflare Pages

Latest commit: ceafe35
Status: ✅  Deploy successful!
Preview URL: https://0dcfd485.react-science.pages.dev
Branch Preview URL: https://728-add-option-to-make-table.react-science.pages.dev

View logs

stropitek
stropitek reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you put the sticky option in the Header component?

CleanShot 2024-05-27 at 10 33 04

We shouldn't be able to see the table rows which are above the header.

@moonayyur
Copy link
Contributor Author

Why didn't you put the sticky option in the Header component?

Should I use cloneElement to pass the prop to Header then ?

@stropitek
Copy link
Contributor

Should I use cloneElement to pass the prop to Header then ?

Can you explain? I don't think you need to do that in order to move the sticky prop from the Table component to the TableHeader component.

@moonayyur moonayyur merged commit 1827fe7 into main May 28, 2024
12 checks passed
@moonayyur moonayyur deleted the 728-add-option-to-make-table-header-sticky branch May 28, 2024 09:41
@zakodium-bot zakodium-bot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stropitek stropitek stropitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to make table header sticky
2 participants
@moonayyur @stropitek