Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide another way of creating the formatError handler which enables importing IoC dependencies #56

Merged

Conversation

stropitek
Copy link
Contributor

No description provided.

@stropitek stropitek linked an issue Jan 9, 2024 that may be closed by this pull request
@stropitek
Copy link
Contributor Author

I tried to create a test case in which the IoC dependency is used but it does not seem possible to create a fake namespace that works with ioc.make()

@targos any pointers?

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a45139) 90.58% compared to head (9ab2943) 91.48%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   90.58%   91.48%   +0.90%     
==========================================
  Files           5        6       +1     
  Lines          85       94       +9     
  Branches       20       23       +3     
==========================================
+ Hits           77       86       +9     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stropitek stropitek enabled auto-merge (squash) January 9, 2024 13:10
@stropitek stropitek enabled auto-merge (squash) January 9, 2024 13:13
@stropitek stropitek merged commit ee27363 into main Jan 9, 2024
7 checks passed
@stropitek stropitek deleted the 55-support-loading-ioc-dependencies-in-error-formatter branch January 9, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loading IoC dependencies in error formatter
2 participants