Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringArray option #1

Closed
sanex3339 opened this issue Feb 21, 2018 · 3 comments
Closed

StringArray option #1

sanex3339 opened this issue Feb 21, 2018 · 3 comments

Comments

@sanex3339
Copy link
Member

Why stringArray option is disabled?

@zakplus
Copy link
Contributor

zakplus commented Feb 21, 2018

Hi Timofey, when stringArray is true, webpack has a problem with the code generated by the obfuscator.
The code itself is correct but it contains "requires" with expressions as arguments (like this: require(_0x430e('0x0'));) and webpack does not like them:

WARNING in ./src/index.js 23:14-37 Critical dependency: the request of a dependency is an expression @ ./src/index.js

When this warning occurs, webpack generates a bundle which is missing the required module.

@sanex3339
Copy link
Member Author

Better parse it and wrap in conditional conments

@zakplus
Copy link
Contributor

zakplus commented Feb 22, 2018

I did not think about it, good advise! I'm releasing a new version without the stringArray limitation.
Thank you Timofey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants