This repository has been archived by the owner on Jan 7, 2022. It is now read-only.
#13 Change the log compaction warning #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmontrieux
suggested changes
Aug 27, 2018
| Help.cleanupPolicy | ||
| Optional | ||
| Enabled | ||
| cleanupPoliciesOptions | ||
| , if (getValue FieldCleanupPolicy formModel.values) == cleanupPolicies.compact then | ||
| p [ class "dc-p" ] | ||
| [ text "Log compacted event types MUST NOT contain personal identifiable" |
There was a problem hiding this comment.
Would it make sense to put this text in some configuration? I imagine that other people who want to deploy nakadi-ui may have different opinions about what should and what should not be allowed to store in log-compacted event types
There was a problem hiding this comment.
Yes. I thought about it but I don't want to blow up configuration just right now. I would wait for some time to settle it down a bit and ideally have a real use case for this config.
lmontrieux
approved these changes
Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #13 the message was changed on the create ET form for the cleanup strategy field.
Support link added.