Skip to content

Commit

Permalink
Examine custom environment sources when syncing.
Browse files Browse the repository at this point in the history
When comparing statefulsets, make sure EnvFrom fields are compared
as well.
  • Loading branch information
alexeyklyukin committed Nov 9, 2017
1 parent 257e0fc commit 4b0c4f1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/cluster/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,10 @@ func (c *Cluster) compareStatefulSetWith(statefulSet *v1beta1.StatefulSet) *comp
needsRollUpdate = true
reasons = append(reasons, "new statefulset's container environment doesn't match the current one")
}
if !reflect.DeepEqual(container1.EnvFrom, container2.EnvFrom) {
needsRollUpdate = true
reasons = append(reasons, "new statefulset's container environment sources doesn't match the current one")
}

if needsRollUpdate || needsReplace {
match = false
Expand Down

0 comments on commit 4b0c4f1

Please sign in to comment.