Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate TTL for newly created stacks #86

Open
aermakov-zalando opened this issue Dec 11, 2018 · 0 comments
Open

Separate TTL for newly created stacks #86

aermakov-zalando opened this issue Dec 11, 2018 · 0 comments

Comments

@aermakov-zalando
Copy link
Contributor

#71 implemented a hacky solution to a problem where the controller scaled down stacks before the deployment even had a chance to switch traffic to those. However, this behaviour is not exactly intuitive, and could lead to deployments being kept alive for longer than necessary if the user quickly switches traffic back and forth. A cleaner approach would be to mark newly created stacks with an annotation that's erased when they get traffic and introducing a separate TTL for stacks in this state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant