Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nested additionalProperties #1138

Merged
merged 1 commit into from Jan 29, 2020
Merged

fix nested additionalProperties #1138

merged 1 commit into from Jan 29, 2020

Conversation

dtkav
Copy link
Collaborator

@dtkav dtkav commented Jan 24, 2020

Fixes #1137
Redo #971

Changes proposed in this pull request:

  • Don't drop nested additionalProperties
  • Remove unnecessary filtering of objects in OAS3 (if it passed validation, it can be used as-is)

@dtkav dtkav mentioned this pull request Jan 24, 2020
Closed
@coveralls
Copy link

coveralls commented Jan 24, 2020 •
edited

Coverage Status

Coverage increased (+0.07%) to 96.241% when pulling 265111b on dtkav:deepObject_fix2 into 4b93890 on zalando:master.

@dtkav dtkav added the bugfix label Jan 24, 2020
@dtkav dtkav requested a review from hjacobs January 27, 2020 06:35
@hjacobs
Copy link
Contributor

hjacobs commented Jan 29, 2020

Thanks @dtkav!

@hjacobs
Copy link
Contributor

hjacobs commented Jan 29, 2020

👍

@hjacobs hjacobs merged commit 3fecd3e into spec-first:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

@drummerwolli drummerwolli Awaiting requested review from drummerwolli

@hjacobs hjacobs Awaiting requested review from hjacobs

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.4+ silently removes additionalProperties from nested objects
4 participants
@dtkav @coveralls @hjacobs @cognifloyd