More liberal flask number converters for float and int in paths #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @logi, thanks for this PR. We switched to the |
logi
force-pushed
the
master
branch
2 times, most recently
from
db3d97c
to
2a7c5fd
Compare
These don't try to enforce a "single representation" of paths but instead try to convert the numbers that callers pass in. Addresses spec-first#1040 and spec-first#1041
|
@RobbeSneyders AFAICT that's done now |
hjacobs
reviewed
Jul 14, 2021
hjacobs
reviewed
Jul 14, 2021
tests/fakeapi/hello/__init__.py
Outdated
|
|
||
|
|
||
| def test_get_somefloat(somefloat): | ||
| return type(somefloat).__name__ | ||
| return '%s %g' % (type(somefloat).__name__, somefloat) |
There was a problem hiding this comment.
Please use "new" Python f-strings (f"{x} {y}")
hjacobs
reviewed
Jul 14, 2021
tests/api/test_parameters.py
Outdated
| app_client = simple_app.app.test_client() | ||
| resp = app_client.get('/v1.0/test-int-path/123') # type: flask.Response | ||
| assert resp.data.decode('utf-8', 'replace') == '"int"\n' | ||
| resp = app_client.get('/v1.0/test-int-path/'+arg) # type: flask.Response |
There was a problem hiding this comment.
Suggested change
| resp = app_client.get('/v1.0/test-int-path/'+arg) # type: flask.Response | |
| resp = app_client.get(f"/v1.0/test-int-path/{arg}") # type: flask.Response |
hjacobs
approved these changes
Jul 14, 2021
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change installs more liberal flask converters for
floatandint. These don't try to enforce a "single representation" of paths but instead try to convert the numbers that callers pass in.This is the minimal change to get this effect and installs the custom number converters where the custom JSON converter is being installed already. An alternative would be to register the new converters as
integerandnumberin Flask and update thePATH_PARAMETER_CONVERTERSmapping, but that's a larger change and would change the generated flask paths which could affect existing code.Fixes #1040
Fixes #1041
The tests for numbers in paths are modified to return not just
intorfloatbut also the value seen by the handler so we can ascertain that the conversion works and not just the routing. Then a few number formats are added.