Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why features are iterated in a for loop? #243

Closed
igusher opened this issue Dec 3, 2018 · 2 comments
Closed

Why features are iterated in a for loop? #243

igusher opened this issue Dec 3, 2018 · 2 comments

Comments

@igusher
Copy link

igusher commented Dec 3, 2018

https://github.com/zalando/expan/blob/master/expan/core/experiment.py#L87

I didn't quite get this for loop. As far as I understand only last feature filter will be applied and all other are ignored? Do I get it right?

@shansfolder
Copy link
Contributor

@igusher It was designed to support multiple feature at the same time. e.g. female chrome user.
So all features defined in the instance of StatisticalTest will be applied.

In Octopus, we only initialize each StatisticalTest with only one feature,

@igusher
Copy link
Author

igusher commented Dec 3, 2018

I see, thanks

@igusher igusher closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants