Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a function to push the metrics as the main function #101

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Use a function to push the metrics as the main function #101

merged 1 commit into from
Mar 2, 2017

Conversation

jmcs
Copy link
Member

@jmcs jmcs commented Mar 2, 2017

The metrics were not being pushed because main() was being executed directly.

@rafaelcaricio
Copy link
Contributor

👍

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 84.454% when pulling 5fe5fd3 on put-metrics-in-the-right-place into ce16e1f on master.

@jmcs jmcs merged commit 499ca59 into master Mar 2, 2017
@jmcs jmcs removed the in progress label Mar 2, 2017
@jkozlowicz
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafaelcaricio rafaelcaricio

@last-ent last-ent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmcs @rafaelcaricio @coveralls @jkozlowicz @last-ent