New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logbook 3.7.0 pulls in Lombok as transitive dependency #1705
Comments
@msdousti it looks like this change started pulling lombok as a compile dependency, because it's declared as such in spring-boot-dependencies. Do you think we can revert to using |
@kasmarian
As a side note, depending on I'll try to dig deeper why Gradle is not behaving as expected. |
I also noticed that maven project doesn't pull lombok, still, with gradle this only happens for 3.0.7 version.
In the parent project, we do specify lombok without a specific scope. Can it be that the scope from spring-boot-dependencies is used in case of a gradle project instead of the scope from logbook-parent's dependencyManagement? |
@kasmarian I believe the the above PR (#1706) fixes this. |
PS: Th answers to this SO question nail it:
I'd say we should review the parent project based on this observation. PS: Did this in my PR. |
We released 3.7.1 where this should be addressed. May take some time until the release is available in repositories |
Thanks for fixing this so quickly. Version
Shall I create a new issue or reopen this one? |
@bwaldvogel Thanks a lot for your report! It will be great if you create a new ticket mentioning all those "badly scoped" dependencies; I'll then fix them in one PR. |
Please see #1711 |
When upgrading Logbook from
3.6.0
to3.7.0
we get a new transitive dependency pulled in:org.projectlombok:lombok:1.18.30
.For projects that are not using Lombok, that causes undesired effects. For example, IntelliJ IDEA auto-discovers that Lombok is used in the project and starts suggesting the use of Lombok annotations.
Steps to reproduce
org.zalando:logbook-spring-boot-starter:3.7.0
Actual behavior
./gradlew -q dependencyInsight --dependency lombok
shows that Lombok is pulled in:When downgrading from
3.7.0
to3.6.0
, the Lombok dependency disappears.Expected behavior
The Lombok is not pulled in as it was in version
3.6.0
.The text was updated successfully, but these errors were encountered: