Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Spring Boot ErrorPageFilter #211

Closed
Anto89 opened this issue Mar 7, 2018 · 4 comments · Fixed by #437
Closed

Conflict with Spring Boot ErrorPageFilter #211

Anto89 opened this issue Mar 7, 2018 · 4 comments · Fixed by #437

Comments

@Anto89
Copy link

Anto89 commented Mar 7, 2018

Hello ! First, thanks a lot for your awesome library !

I didn't see that this issue has already been reported even if some are close to what I encountered.

I get a conflict with ErrorPageFilter in non-embedded containers, the result is that the Spring Boot Whitelabel Error Page doesn't display. I have an error log similar to this one :
2018-03-06 22:05:05.752 ERROR 8600 --- [nio-8080-exec-6] o.s.boot.web.support.ErrorPageFilter : Cannot forward to error page for request [/test] as the response has already been committed. As a result, the response may have the wrong status code. If your application is running on WebSphere Application Server you may be able to resolve this problem by setting com.ibm.ws.webcontainer.invokeFlushAfterService to false

The issue can easily be reproduced with a plain Spring Boot application like this one. Deploy it to Tomcat (non-embedded) and hit a path that is unknown to the server.

@whiskeysierra
Copy link
Collaborator

Looks like it's related to #155

@Anto89
Copy link
Author

Anto89 commented Mar 7, 2018

I tried with the latest version of Spring boot 2.0.0.RELEASE but the issue is still there.

@whiskeysierra
Copy link
Collaborator

Do you actually need the ErrorPageFilter?

@Anto89
Copy link
Author

Anto89 commented Mar 7, 2018

Yes, actually the company I'm working for use it to handle all exceptions that may not have been handled in specific handler classes and/or handler methods.

@whiskeysierra whiskeysierra mentioned this issue Feb 24, 2019
6 tasks
@whiskeysierra whiskeysierra added this to the 2.0.0 milestone Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants