Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current behavior deletes expected responses from all providers after successful flow #6

Closed
prayerslayer opened this issue Nov 9, 2015 · 2 comments
Closed

Current behavior deletes expected responses from all providers after successful flow #6

prayerslayer opened this issue Nov 9, 2015 · 2 comments
Labels
bug

Comments

@prayerslayer
Copy link
Contributor

Because it's just localStorage.clear().
@prayerslayer prayerslayer changed the title Current behavior deletes expected responses from all providers Current behavior deletes expected responses from all providers after successful flow Nov 9, 2015
@prayerslayer
Copy link
Contributor Author

Actually that deletes EVERYTHING 😱

@prayerslayer prayerslayer mentioned this issue Nov 10, 2015
Merged
prayerslayer added a commit that referenced this issue Nov 10, 2015
@prayerslayer
#6 safe delete of objects
54ffa37
@prayerslayer prayerslayer mentioned this issue Nov 10, 2015
Closed
prayerslayer added a commit that referenced this issue Nov 10, 2015
@prayerslayer
Merge pull request #7 from zalando/6-safe-delete
098e176 
#6 safe delete of objects
@prayerslayer
Copy link
Contributor Author

In 0.0.17 LocalStorage now only removes items prefixed by its given prefix. Sorry for the potential harm here. Will update the tests accordingly.

prayerslayer added a commit that referenced this issue Nov 10, 2015
@prayerslayer
#6 build
01e62ef
prayerslayer added a commit that referenced this issue Nov 10, 2015
@prayerslayer
#6 update tests to include a proper localstorage mock
e4c7fce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prayerslayer