Ensure correlation via baggage on forwarded spans #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasniemeier-zalando
requested review from
AlexanderYastrebov,
pc-alves,
whiskeysierra and
zeitlinger
as code owners
zeitlinger
approved these changes
Apr 15, 2020
|
👍 |
|
@lukasniemeier-zalando the commit is not signed |
* change active-span-check to assert on span-id only to not fail if spans are wrapped (forwarded) e.g. due to auto-tagging
lukasniemeier-zalando
force-pushed
the
forwarded-baggage-correlation
branch
from
fe08aea
to
7c4d008
Compare
|
@zeitlinger thanks for the hint, fixed |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
MDCas configured for log correlation.Types of changes
Checklist: