Logical backup retention time #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the script will work with older operator versions
stoewer
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
👍 |
|
👍 |
1 similar comment
|
👍 |
|
Thanks @stoewer for your contribution and sorry it took us so long to merge. |
|
How do we configure this from the CRD config? |
|
@Routhinator what do you mean? You can set |
|
I mean I would like to set this for the cluster CRD so that different clusters have different retention. I found the global config - but I need per-cluster config. |
|
Hello, what happened when the postgres CR is deleted. Backup are not cleaned up anymore, right ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to configure a retention time for logical backups (as described in #1008).
The cleanup of logical backup objects, older than the defined retention period, is implemented in the
dump.shscript and will only run after a successful upload of a new backup.The retention time can be configured using the parameter
logical_backup_s3_retention_time. Values can be specified in a human friendly format such as1 weekor2 months. Values shorter than one day (e.g.3 hours) are accepted but will be rounded up to a full day. As a precaution the cleanup procedure will always spare the newest backup that is older than the retention time.