feat: add ignored annotations #1485
Conversation
moshloop
requested review from
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
Co-authored-by: Felix Kunde <felix-kunde@gmx.de>
|
@moshloop looks good overall. However, I do not see why it is necessary to move things around. Comparing two K8s services seems fine under k8sutil. You can also move your new unit test there. Then this PR would be only about the new feature and easier to review. |
| @@ -36,6 +38,7 @@ func init() { | |||
| flag.BoolVar(&config.NoTeamsAPI, "noteamsapi", false, "Disable all access to the teams API") | |||
| flag.Parse() | |||
|
|
|||
| config.IgnoredAnnotations = strings.Split(os.Getenv("IGNORED_ANNOTATIONS"), ",") | |||
There was a problem hiding this comment.
Can be removed. Operator configuration should happen via ConfigMap or CRD. The other options here are for the operator deployment object.
|
@moshloop can you rebase with the master and reflect my last comment? I would also appreciate coverage in unit and e2e tests. Should be quite easy to add |
|
@FxKu will do |
|
any update here @moshloop ? Was thinking, if we can include it in the next release. |
|
@FxKu Sorry I am a little swamped at the moment I can probably pick this up in a week or 2. |
|
@moshloop any update? Seems like other users / frameworks need this feature. |
|
@moshloop ping? |
|
@FxKu Sorry, I am still snowed under, I am going to try to get someone else on my team to pick this up |
In a slightly different approach to #1482 This adds a new configuration parameter that allows ignoring annotations across services, stateful sets, and pods