Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add extraEnvs to operator-ui helm chart #1582

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Conversation

golgoth31
Copy link
Contributor

This PR allows adding any needed extra anv vars to the operator-ui deployment into the helm chart.
Fixes #1523

fix: Not working if extraEnvs is empty
@FxKu
Copy link
Member

FxKu commented Aug 17, 2021

Thanks. Lets add these commented lines directly to the deployment template and example manifest.

@golgoth31
Copy link
Contributor Author

Is it what you intended ?

@FxKu
Copy link
Member

FxKu commented Aug 18, 2021

Yes and the same for helm chart, too. This extraEnvs construct looks kinda strange to me.

@golgoth31
Copy link
Contributor Author

I have added some comments in the values.yaml file the extraEnvs field

# configure extra UI ENVs
# Extra ENVs are writen in kubenertes format and added "as is" to the pod's env variables
# https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/
# https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#environment-variables
# UI specific env variables can be found here: https://github.com/zalando/postgres-operator/blob/master/ui/operator_ui/main.py

does it seems ok ?

@Jan-M
Copy link
Member

Jan-M commented Aug 20, 2021

👍

1 similar comment
@FxKu
Copy link
Member

FxKu commented Aug 20, 2021

👍

@FxKu FxKu merged commit f105533 into zalando:master Aug 20, 2021
@FxKu
Copy link
Member

FxKu commented Aug 20, 2021

Thanks @golgoth31 for your contribution! 😃

@golgoth31
Copy link
Contributor Author

Thank you for this amazing job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgre Operator UI chart improvement
3 participants