-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toleration diff and nodeReadinessLabel merge with manifest matchExpressions #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
CyberDem0n,
erthalion,
Jan-M and
sdudoladov
as code owners
December 23, 2021 11:07
make taint e2e test more robust change merge behavior of nodeSelectorTerms for node readiness label
FxKu
changed the title
include toleration in statefulset comparison
toleration diff and nodeReadinessLabel merge with manifest matchExpressions
Jan 6, 2022
sdudoladov
reviewed
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add 2 examples (for OR and
AND`) to the admin docs showcasing the different behavior ?
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding tolerations to the manifest it will simply be ignored since the comparison between running and desired stateful set does not yield a mismatch. This PR will introduce a rolling update trigger for toleration changes just like with
nodeAffinity
. Only slice length is compared for now.With nodeAffinity we spotted another problem: If somebody specified
nodeAffinity
in the manifest and has configurednode_readiness_label
the resulting affinity on the pods will have twomatchExpressions
section in thenodeSelectorTerms
.Multiple
matchExpressions
are evaluated with OR condition. Thus, pods could be scheduled on nodes having either one of the specified expressions. This might be fine for some users. However, we want the readiness label to be evaluated always together with other specified affinities. Therefore, we will introduce another option to choose if the config affinity should get merged under onematchExpressions
(AND) or stay in it's own (OR).Finally, this PR also tries to re-enable the taint based eviction and node readiness label tests which use the features touched here.