Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inherited_labels and inherited_annotations not passed to PVC #1784

Merged
merged 2 commits into from Mar 1, 2022
Merged

inherited_labels and inherited_annotations not passed to PVC #1784

merged 2 commits into from Mar 1, 2022

Conversation

dmvolod
Copy link
Contributor

@dmvolod dmvolod commented Feb 16, 2022

Fixes #1754
Fixes #1783

@FxKu
Copy link
Member

FxKu commented Mar 1, 2022

👍

@FxKu FxKu added this to the 1.8 milestone Mar 1, 2022
@jopadi
Copy link
Member

jopadi commented Mar 1, 2022

👍

@FxKu FxKu merged commit da83982 into zalando:master Mar 1, 2022
@FxKu
Copy link
Member

FxKu commented Mar 1, 2022

Thanks @dmvolod for you contribution. Fixing two issues at once is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

inherited_labels are not propagated to the PersistentVolumeClaim inherited_annotations not passed to PVC
3 participants
@dmvolod @FxKu @jopadi