Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CI for UI, Logical Backup Images to GHCR #2527

Merged
merged 4 commits into from Feb 14, 2024

Conversation

dgiebert
Copy link
Contributor

Closes #2303 #2313

@FxKu
Copy link
Member

FxKu commented Feb 5, 2024

@dgiebert can you rebase? I merged #2426 which only provided changes to UI image. Could you split up the steps for all images like it was done in the other PR that I merged? Thanks :)

@lyz-code
Copy link

lyz-code commented Feb 5, 2024

@dgiebert would it be possible if you add also support for the pooler? it's the piece that is preventing us from having full ARM support

@dgiebert
Copy link
Contributor Author

dgiebert commented Feb 5, 2024

@dgiebert would it be possible if you add also support for the pooler? it's the piece that is preventing us from having full ARM support

If you could point me to the Dockerfile, I can add it!

@dgiebert can you rebase? I merged #2426 which only provided changes to UI image. Could you split up the steps for all images like it was done in the other PR that I merged? Thanks :)

@FxKu I can surely do that! I did split the container image building, but do you also want me to split the name generation then?

Regarding the merged PR #2426 I had to build the frontend and bundle it in, do you prefer to have this done via Github Actions or Multistage?

@FxKu FxKu added this to the 1.11.0 milestone Feb 5, 2024
@FxKu
Copy link
Member

FxKu commented Feb 6, 2024

I can surely do that! I did split the container image building, but do you also want me to split the name generation then?

Splitting it up sounds cleaner to me.

Regarding the merged PR #2426 I had to build the frontend and bundle it in, do you prefer to have this done via Github Actions or Multistage?

You mean different Github actions for different tools vs. all tools in multiple stages on one action? If yes, I would prefer the latter.

Note, the pooler image is not part of this OS repo. I will take care of it to make it arm-ready for the release.

@lyz-code
Copy link

lyz-code commented Feb 6, 2024

I've been searching for the dockerfile but it looks like it's not yet open source :(

@FxKu is it in your roadmap to either opensource the image or to give ARM support? This is preventing us from deploying postgres in HA

@FxKu
Copy link
Member

FxKu commented Feb 6, 2024

@lyz-code seems you did not read the last sentence of my last post. Pooler will get arm support, too.

@bwrobc
Copy link

bwrobc commented Feb 9, 2024

Pooler will get arm support, too.

@FxKu are you planning on publishing the source code changes, or just providing an ARM build?

@FxKu
Copy link
Member

FxKu commented Feb 13, 2024

I have resolved the conflicts. We do have the pooler image arm-ready to (master-33) but I will bump this in another PR

@dgiebert
Copy link
Contributor Author

Thank you for fixing it; I was busy last week.

Is there still anything I need to do so this gets merged?

You mean different Github actions for different tools vs. all tools in multiple stages on one action? If yes, I would prefer the latter.

So I adapted the ui/Dockerfile to be multistage, but this could also be done in CI instead (I preferred the multi-stage)

@hughcapet
Copy link
Member

👍

1 similar comment
@FxKu
Copy link
Member

FxKu commented Feb 14, 2024

👍

@FxKu FxKu merged commit 569fc57 into zalando:master Feb 14, 2024
4 of 5 checks passed
@FxKu
Copy link
Member

FxKu commented Feb 14, 2024

Thanks @dgiebert . I will do some further testing with this new UI image.

@cyrinux
Copy link

cyrinux commented Feb 14, 2024

Can you please give me please the new docker images path for both operator and the ui please? I can find docker pull ghcr.io/zalando/postgres-operator:v1.10.1 but what is the one for the ui ? (for arm64)

@mmoscher
Copy link

@cyrinux as you can see in the workflow definition, this GHA workflow will only run on tag. Since no new tag was pushed lately, you won't find any of the new images (ui, logical backup) yet.

@cyrinux
Copy link

cyrinux commented Feb 14, 2024

@cyrinux as you can see in the workflow definition, this GHA workflow will only run on tag. Since no new tag was pushed lately, you won't find any of the new images (ui, logical backup) yet.

Thank @mmoscher, didn't see well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change alpine:3.15 for ARM support in the UI
7 participants