Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally enable init/sidecar containers #464

Closed
sdudoladov opened this issue Jan 29, 2019 · 2 comments · Fixed by #478
Closed

Optionally enable init/sidecar containers #464

sdudoladov opened this issue Jan 29, 2019 · 2 comments · Fixed by #478
Assignees

Comments

@sdudoladov
Copy link
Member

The operator currently support running sidecar and init containers side-by-side with Postgres containers. For maintenance reasons , we would like to be able to enable/disable these features per k8s cluster. The task is to:

  1. Add relevant toggles to the operator configuration (CRD and configmap) similar to existing boolean options such as enable_shm_volume.
  2. Log a warning if a user attempts to use init/sidecars containers when this feature is disabled.
@redbaron
Copy link
Contributor

redbaron commented Jan 29, 2019

IMHO it should be a hard error and no Postgres resources to be created

@sdudoladov
Copy link
Member Author

we also may need to restrict the ability to re-write tolerations/timeouts in a similar fashion

IMHO it should be a hard error and no Postgres resources to be created

Good point 👍 Sadly in the present operator codebase there is no single place where we can validate all the (un)desired properties of the PG manifest, so to make it a hard error we can, for instance, put a separate check in the beginning of Sync and Create methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants