Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Move requirements inside setup.py gated by version #12

Closed
cooperlees opened this issue Aug 3, 2018 · 1 comment · Fixed by #21
Closed

Move requirements inside setup.py gated by version #12

cooperlees opened this issue Aug 3, 2018 · 1 comment · Fixed by #21

Comments

@cooperlees
Copy link

cooperlees commented Aug 3, 2018 •
edited
Loading

argparse is not really needed except in older version of Python. How do you feel about moving them into setup.py and gating them for < 2.7 and < 3.3 ?

Context: @ Facebook we build modules into our own wheels and auto generate dependencies. Your modules, even with Python 3.6 today insists on these modules so our automation co-operates.

Many thanks for the module!
@cooperlees cooperlees changed the title More requirements inside setup.py gated by version Move requirements inside setup.py gated by version Aug 3, 2018
@hjacobs
Copy link
Contributor

hjacobs commented Aug 3, 2018

Sounds good, feel free to open a PR!

@dalazx dalazx mentioned this issue Mar 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added python_version conditions to requirements.txt dalazx/python-nsenter
2 participants
@hjacobs @cooperlees