/
oidc.go
590 lines (525 loc) · 16.3 KB
/
oidc.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
package auth
import (
"context"
"crypto/sha256"
"encoding/json"
"fmt"
"io"
"math/rand"
"net"
"net/http"
"net/url"
"strings"
"time"
"github.com/coreos/go-oidc"
log "github.com/sirupsen/logrus"
"github.com/zalando/skipper/filters"
"github.com/zalando/skipper/secrets"
"golang.org/x/oauth2"
)
const (
OidcUserInfoName = "oauthOidcUserInfo"
OidcAnyClaimsName = "oauthOidcAnyClaims"
OidcAllClaimsName = "oauthOidcAllClaims"
oauthOidcCookieName = "skipperOauthOidc"
stateValidity = 1 * time.Minute
oidcInfoHeader = "Skipper-Oidc-Info"
)
type (
tokenOidcSpec struct {
typ roleCheckType
SecretsFile string
secretsRegistry *secrets.Registry
}
tokenOidcFilter struct {
typ roleCheckType
config *oauth2.Config
provider *oidc.Provider
verifier *oidc.IDTokenVerifier
claims []string
validity time.Duration
cookiename string
redirectPath string
encrypter secrets.Encryption
authCodeOptions []oauth2.AuthCodeOption
}
userInfoContainer struct {
OAuth2Token *oauth2.Token `json:"oauth2token"`
UserInfo *oidc.UserInfo `json:"userInfo"`
Subject string `json:"subject"`
}
claimsContainer struct {
OAuth2Token *oauth2.Token `json:"oauth2token"`
Claims map[string]interface{} `json:"claims"`
Subject string `json:"subject"`
}
)
// NewOAuthOidcUserInfos creates filter spec which tests user info.
func NewOAuthOidcUserInfos(secretsFile string, secretsRegistry *secrets.Registry) filters.Spec {
return &tokenOidcSpec{typ: checkOIDCUserInfo, SecretsFile: secretsFile, secretsRegistry: secretsRegistry}
}
// NewOAuthOidcAnyClaims creates a filter spec which verifies that the token
// has one of the claims specified
func NewOAuthOidcAnyClaims(secretsFile string, secretsRegistry *secrets.Registry) filters.Spec {
return &tokenOidcSpec{typ: checkOIDCAnyClaims, SecretsFile: secretsFile, secretsRegistry: secretsRegistry}
}
// NewOAuthOidcAllClaims creates a filter spec which verifies that the token
// has all the claims specified
func NewOAuthOidcAllClaims(secretsFile string, secretsRegistry *secrets.Registry) filters.Spec {
return &tokenOidcSpec{typ: checkOIDCAllClaims, SecretsFile: secretsFile, secretsRegistry: secretsRegistry}
}
// CreateFilter creates an OpenID Connect authorization filter.
//
// first arg: a provider, for example "https://accounts.google.com",
// which has the path /.well-known/openid-configuration
//
// Example:
//
// oauthOidcAllClaims("https://accounts.identity-provider.com", "some-client-id", "some-client-secret",
// "http://callback.com/auth/provider/callback", "scope1 scope2", "claim1 claim2") -> "https://internal.example.org";
func (s *tokenOidcSpec) CreateFilter(args []interface{}) (filters.Filter, error) {
sargs, err := getStrings(args)
if err != nil {
return nil, err
}
if len(sargs) <= 4 {
return nil, filters.ErrInvalidFilterParameters
}
providerURL, err := url.Parse(sargs[0])
if err != nil {
log.Errorf("Failed to parse url %s: %v", sargs[0], err)
return nil, filters.ErrInvalidFilterParameters
}
ctx := context.Background()
provider, err := oidc.NewProvider(ctx, providerURL.String())
if err != nil {
log.Errorf("Failed to create new provider %s: %v", providerURL, err)
return nil, filters.ErrInvalidFilterParameters
}
if err != nil {
log.Errorf("Failed to create ciphersuite: %v", err)
return nil, filters.ErrInvalidFilterParameters
}
h := sha256.New()
for _, s := range sargs {
h.Write([]byte(s))
}
byteSlice := h.Sum(nil)
sargsHash := fmt.Sprintf("%x", byteSlice)[:8]
generatedCookieName := oauthOidcCookieName + sargsHash
log.Debugf("Generated Cookie Name: %s", generatedCookieName)
redirectURL, err := url.Parse(sargs[3])
if err != nil {
return nil, fmt.Errorf("the redirect url %s is not valid: %v", sargs[3], err)
}
encrypter, err := s.secretsRegistry.NewEncrypter(1*time.Minute, s.SecretsFile)
if err != nil {
return nil, err
}
f := &tokenOidcFilter{
typ: s.typ,
redirectPath: redirectURL.Path,
config: &oauth2.Config{
ClientID: sargs[1],
ClientSecret: sargs[2],
RedirectURL: sargs[3], // self endpoint
Endpoint: provider.Endpoint(),
Scopes: []string{oidc.ScopeOpenID},
},
provider: provider,
verifier: provider.Verifier(&oidc.Config{
ClientID: sargs[1],
}),
validity: 1 * time.Hour,
cookiename: generatedCookieName,
encrypter: encrypter,
}
switch f.typ {
case checkOIDCUserInfo:
f.config.Scopes = append(f.config.Scopes, sargs[4:]...)
case checkOIDCAnyClaims:
fallthrough
case checkOIDCAllClaims:
additionScopes := sargs[4]
f.config.Scopes = append(f.config.Scopes, additionScopes)
f.claims = strings.Split(sargs[5], " ")
default:
return nil, filters.ErrInvalidFilterParameters
}
f.authCodeOptions = make([]oauth2.AuthCodeOption, 0)
if len(sargs) > 6 {
extraParameters := strings.Split(sargs[6], " ")
for _, p := range extraParameters {
splitP := strings.Split(p, "=")
log.Debug(splitP)
if len(splitP) != 2 {
return nil, filters.ErrInvalidFilterParameters
}
f.authCodeOptions = append(f.authCodeOptions, oauth2.SetAuthURLParam(splitP[0], splitP[1]))
}
}
log.Debugf("Auth Code Options: %v", f.authCodeOptions)
return f, nil
}
func (s *tokenOidcSpec) Name() string {
switch s.typ {
case checkOIDCUserInfo:
return OidcUserInfoName
case checkOIDCAnyClaims:
return OidcAnyClaimsName
case checkOIDCAllClaims:
return OidcAllClaimsName
}
return AuthUnknown
}
func (f *tokenOidcFilter) validateAnyClaims(h map[string]interface{}) bool {
if len(f.claims) == 0 {
return true
}
var a []string
for k := range h {
a = append(a, k)
}
log.Debugf("intersect(%v, %v)", f.claims, a)
return intersect(f.claims, a)
}
func (f *tokenOidcFilter) validateAllClaims(h map[string]interface{}) bool {
if len(f.claims) == 0 {
return true
}
var a []string
for k := range h {
a = append(a, k)
}
log.Debugf("all(%v, %v)", f.claims, a)
return all(f.claims, a)
}
const (
secretSize = 20
letterBytes = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
letterIdxBits = 6 // 6 bits to represent a letter index
letterIdxMask = 1<<letterIdxBits - 1 // All 1-bits, as many as letterIdxBits
letterIdxMax = 63 / letterIdxBits // # of letter indices fitting in 63 bits
)
var (
src = rand.NewSource(time.Now().UnixNano())
)
// https://stackoverflow.com/questions/22892120/how-to-generate-a-random-string-of-a-fixed-length-in-golang
func randString(n int) string {
b := make([]byte, n)
// A src.Int63() generates 63 random bits, enough for letterIdxMax characters!
for i, cache, remain := n-1, src.Int63(), letterIdxMax; i >= 0; {
if remain == 0 {
cache, remain = src.Int63(), letterIdxMax
}
if idx := int(cache & letterIdxMask); idx < len(letterBytes) {
b[i] = letterBytes[idx]
i--
}
cache >>= letterIdxBits
remain--
}
return string(b)
}
type OauthState struct {
Rand string `json:"rand"`
Validity int64 `json:"validity"`
Nonce string `json:"none"`
RedirectUrl string `json:"redirectUrl"`
}
func createState(nonce []byte, redirectUrl string) ([]byte, error) {
state := &OauthState{
Rand: randString(secretSize),
Validity: time.Now().Add(stateValidity).Unix(),
Nonce: fmt.Sprintf("%x", nonce),
RedirectUrl: redirectUrl,
}
return json.Marshal(state)
}
func extractState(encState []byte) (*OauthState, error) {
var state OauthState
err := json.Unmarshal(encState, &state)
if err != nil {
return nil, err
}
return &state, nil
}
func (f *tokenOidcFilter) internalServerError(ctx filters.FilterContext) {
rsp := &http.Response{
StatusCode: http.StatusInternalServerError,
}
ctx.Serve(rsp)
}
func (f *tokenOidcFilter) doOauthRedirect(ctx filters.FilterContext) {
nonce, err := f.encrypter.CreateNonce()
if err != nil {
log.Errorf("Failed to create nonce: %v", err)
f.internalServerError(ctx)
return
}
redirectUrl := ctx.Request().URL.String()
statePlain, err := createState(nonce, redirectUrl)
if err != nil {
log.Errorf("failed to create oauth2 state: %v", err)
f.internalServerError(ctx)
return
}
stateEnc, err := f.encrypter.Encrypt(statePlain)
if err != nil {
log.Errorf("Failed to encrypt data block: %v", err)
f.internalServerError(ctx)
return
}
oauth2URL := f.config.AuthCodeURL(fmt.Sprintf("%x", stateEnc), f.authCodeOptions...)
rsp := &http.Response{
Header: http.Header{
"Location": []string{oauth2URL},
},
StatusCode: http.StatusTemporaryRedirect,
Status: "Moved Temporarily",
}
log.Infof("serve redirect: plaintextState:%s to Location: %s", statePlain, rsp.Header.Get("Location"))
ctx.Serve(rsp)
}
func (f *tokenOidcFilter) Response(filters.FilterContext) {}
func extractDomainFromHost(host string) string {
h, _, err := net.SplitHostPort(host)
if err != nil {
h = host
}
ip := net.ParseIP(h)
if ip != nil {
return ip.String()
}
if strings.Count(h, ".") < 2 {
return h
}
return strings.Join(strings.Split(h, ".")[1:], ".")
}
func getHost(request *http.Request) string {
if h := request.Header.Get("host"); h != "" {
return h
} else {
return request.Host
}
}
func (f *tokenOidcFilter) doDownstreamRedirect(ctx filters.FilterContext, oidcState []byte, redirectUrl string) {
log.Debugf("Doing Downstream Redirect to :%s", redirectUrl)
host := getHost(ctx.Request())
cookieHeaderVal := fmt.Sprintf("%s=%x; Path=/; HttpOnly; MaxAge=%d; Domain=%s",
f.cookiename, oidcState, int(f.validity.Seconds()), extractDomainFromHost(host))
if ctx.Request().TLS != nil {
cookieHeaderVal = fmt.Sprintf("%s; Secure", cookieHeaderVal)
}
r := &http.Response{
StatusCode: http.StatusTemporaryRedirect,
Header: map[string][]string{
"Set-Cookie": {cookieHeaderVal},
"Location": {redirectUrl},
},
}
ctx.Serve(r)
}
func (f *tokenOidcFilter) validateCookie(cookie *http.Cookie) ([]byte, bool) {
if cookie == nil {
log.Debugf("Cookie is nil")
return nil, false
}
log.Debugf("validate cookie name: %s", f.cookiename)
var cookieStr string
fmt.Sscanf(cookie.Value, "%x", &cookieStr)
decryptedCookie, err := f.encrypter.Decrypt([]byte(cookieStr))
if err != nil {
log.Debugf("Decrypting the cookie failed: %v", err)
return nil, false
}
return []byte(decryptedCookie), true
}
func (f *tokenOidcFilter) Request(ctx filters.FilterContext) {
var (
oauth2Token *oauth2.Token
)
r := ctx.Request()
sessionCookie, _ := r.Cookie(f.cookiename)
cookie, ok := f.validateCookie(sessionCookie)
var (
data []byte
)
log.Debugf("Cookie Validation: %v", ok)
if !ok {
if strings.Contains(ctx.Request().URL.Path, f.redirectPath) {
oauthState, err := f.getCallbackState(ctx)
if err != nil {
unauthorized(ctx, "failed to get state from callback: "+err.Error(), invalidToken, r.Host)
return
}
oauth2Token, err = f.getTokenWithExchange(oauthState, ctx)
if err != nil {
unauthorized(ctx, "Failed to get token in callback: "+err.Error(), invalidToken, r.Host)
return
}
switch f.typ {
case checkOIDCUserInfo:
userInfo, err := f.provider.UserInfo(r.Context(), oauth2.StaticTokenSource(oauth2Token))
if err != nil {
unauthorized(ctx, "Failed to get userinfo: "+err.Error(), invalidToken, r.Host)
return
}
sub := userInfo.Subject
resp := userInfoContainer{oauth2Token, userInfo, sub}
data, err = json.Marshal(resp)
if err != nil {
unauthorized(ctx, fmt.Sprintf("Failed to marshal userinfo backend data for sub=%s: %v", sub, err), invalidToken, r.Host)
return
}
case checkOIDCAnyClaims:
fallthrough
case checkOIDCAllClaims:
tokenMap, sub, err := f.tokenClaims(ctx, oauth2Token)
if err != nil {
log.Debugf("Failed to get claims: %v", err)
unauthorized(ctx, fmt.Sprintf("received token does not contain the claims %s", f.claims), invalidToken, r.Host)
return
}
resp := claimsContainer{OAuth2Token: oauth2Token, Claims: tokenMap, Subject: sub}
data, err = json.Marshal(resp)
if err != nil {
unauthorized(ctx, "failed to serialize claims", invalidSub, r.Host)
return
}
}
encryptedData, err := f.encrypter.Encrypt(data)
if err != nil {
unauthorized(ctx, "failed to encrypt the returned oidc data", invalidSub, r.Host)
return
}
f.doDownstreamRedirect(ctx, encryptedData, oauthState.RedirectUrl)
return
}
f.doOauthRedirect(ctx)
return
}
var (
sub string
allowed bool
oidcInfo interface{}
)
// filter specific checks
switch f.typ {
case checkOIDCUserInfo:
var container userInfoContainer
err := json.Unmarshal([]byte(cookie), &container)
if err != nil {
unauthorized(ctx, "failed to deserialize cookie: "+err.Error(), invalidToken, r.Host)
return
}
if container.OAuth2Token.Valid() && container.UserInfo != nil {
allowed = true
}
oidcInfo = container
sub = container.Subject
case checkOIDCAnyClaims:
var container claimsContainer
err := json.Unmarshal([]byte(cookie), &container)
if err != nil {
unauthorized(ctx, "failed to deserialize cookie: "+err.Error(), invalidToken, r.Host)
return
}
allowed = f.validateAnyClaims(container.Claims)
log.Debugf("validateAnyClaims: %v", allowed)
oidcInfo = container
sub = container.Subject
case checkOIDCAllClaims:
var container claimsContainer
err := json.Unmarshal([]byte(cookie), &container)
if err != nil {
unauthorized(ctx, "failed to deserialize cookie: "+err.Error(), invalidToken, r.Host)
return
}
allowed = f.validateAllClaims(container.Claims)
log.Debugf("validateAllClaims: %v", allowed)
sub = container.Subject
oidcInfo = container
default:
unauthorized(ctx, "unknown", invalidFilter, r.Host)
return
}
if !allowed {
unauthorized(ctx, sub, invalidClaim, r.Host)
return
}
oidcInfoJson, err := json.Marshal(oidcInfo)
if err != nil {
f.internalServerError(ctx)
return
}
ctx.Request().Header.Add(oidcInfoHeader, string(oidcInfoJson))
}
func (f *tokenOidcFilter) tokenClaims(ctx filters.FilterContext, oauth2Token *oauth2.Token) (map[string]interface{}, string, error) {
r := ctx.Request()
rawIDToken, ok := oauth2Token.Extra("id_token").(string)
if !ok {
return nil, "", fmt.Errorf("invalid token, no id_token field in oauth2 token")
}
var idToken *oidc.IDToken
idToken, err := f.verifier.Verify(r.Context(), rawIDToken)
if err != nil {
return nil, "", err
}
tokenMap := make(map[string]interface{})
if err = idToken.Claims(&tokenMap); err != nil {
return nil, "", err
}
sub, ok := tokenMap["sub"].(string)
if !ok {
return nil, "", fmt.Errorf("claims does not contain sub")
}
return tokenMap, sub, nil
}
func (f *tokenOidcFilter) getCallbackState(ctx filters.FilterContext) (*OauthState, error) {
// CSRF protection using similar to
// https://www.owasp.org/index.php/Cross-Site_Request_Forgery_(CSRF)_Prevention_Cheat_Sheet#Encrypted_Token_Pattern,
// because of https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest
r := ctx.Request()
stateQueryEncHex := r.URL.Query().Get("state")
if stateQueryEncHex == "" {
return nil, fmt.Errorf("no state parameter")
}
stateQueryEnc := make([]byte, len(stateQueryEncHex))
if _, err := fmt.Sscanf(stateQueryEncHex, "%x", &stateQueryEnc); err != nil && err != io.EOF {
log.Errorf("Failed to read hex string: %v", err)
return nil, err
}
stateQueryPlain, err := f.encrypter.Decrypt(stateQueryEnc)
if err != nil {
// TODO: Implement metrics counter for number of incorrect tokens
log.Errorf("token from state query is invalid: %v", err)
return nil, err
}
log.Debugf("len(stateQueryPlain): %d, stateQueryEnc: %d, stateQueryEncHex: %d", len(stateQueryPlain), len(stateQueryEnc), len(stateQueryEncHex))
state, err := extractState(stateQueryPlain)
if err != nil {
log.Errorf("Failed to deserialize state: %v", err)
return nil, err
}
return state, nil
}
func (f *tokenOidcFilter) getTokenWithExchange(state *OauthState, ctx filters.FilterContext) (*oauth2.Token, error) {
r := ctx.Request()
if state.Validity < time.Now().Unix() {
log.Errorf("state is no longer valid. %v", state.Validity)
return nil, fmt.Errorf("validity of state expired")
}
// authcode flow
code := r.URL.Query().Get("code")
oauth2Token, err := f.config.Exchange(r.Context(), code, f.authCodeOptions...)
if err != nil {
unauthorized(ctx, "Failed to exchange token: "+err.Error(), invalidClaim, r.Host)
return nil, err
}
return oauth2Token, err
}
func (f *tokenOidcFilter) Close() error {
f.encrypter.Close()
return nil
}