Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky TestAdmissionControl #2386

Open
AlexanderYastrebov opened this issue Jun 9, 2023 · 4 comments
Open

Flaky TestAdmissionControl #2386

AlexanderYastrebov opened this issue Jun 9, 2023 · 4 comments

Comments

@AlexanderYastrebov
Copy link
Member

TestAdmissionControl fails quite often:

--- FAIL: TestAdmissionControl (7.01s)
    --- FAIL: TestAdmissionControl/small_error_rate_and_bigger_than_threshold_will_block_some_traffic (1.00s)
        admission_test.go:187: ok: 1312.00, fail: 278.00, failBackend: 357.00
        admission_test.go:193: Failed to get expected fails should be in: 61.65 < 278.00 < 256.35

E.g. https://github.com/zalando/skipper/actions/runs/5223927424/jobs/9431473370?pr=2385

@szuecs
Copy link
Member

szuecs commented Jun 9, 2023

Yeah I wonder why

@MustafaSaber
Copy link
Member

I tried to re-produce this go test -v -test.short -race -count 100 -run TestAdmissionControl/small_error_rate_and_bigger_than_threshold_will_block_some_traffic ./filters/shedder

@AlexanderYastrebov
Copy link
Member Author

Related #2319

@AlexanderYastrebov AlexanderYastrebov changed the title Fix flaky TestAdmissionControl Flaky TestAdmissionControl Aug 31, 2023
@AlexanderYastrebov
Copy link
Member Author

--- FAIL: TestAdmissionControl (9.03s)
    --- FAIL: TestAdmissionControl/medium_error_rate_and_bigger_than_threshold_will_block_some_traffic (1.00s)
        admission_test.go:225: ok: 424.00, fail: 465.00, failBackend: 355.00
        admission_test.go:231: Failed to get expected fails should be in: 484.54 < 465.00 < 608.94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants