Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Add a configurable fixture template #49

Closed
ridoo opened this issue Aug 8, 2023 · 1 comment · Fixed by #50
Closed

Task: Add a configurable fixture template #49

ridoo opened this issue Aug 8, 2023 · 1 comment · Fixed by #50
Assignees
Labels
feature new required feature good first issue Good for newcomers

Comments

@ridoo
Copy link
Contributor

ridoo commented Aug 8, 2023

Task Description

It would be nice to have a manifest which includes fixtures which are configurable via values.yaml.

Additional Information

  • Use {{ toYaml .Values.geonodeFixtures | nindent 2 }} to include the fixtures.

Not sure about auto loading the fixtures via python manage.py loaddata <yourfixturehere>. For now this would have be done manually. What is your opinion on this @mwallschlaeger ?

@ridoo ridoo added good first issue Good for newcomers feature new required feature labels Aug 8, 2023
@ridoo ridoo self-assigned this Aug 8, 2023
@mwallschlaeger
Copy link
Contributor

I'm open to this idea. Using the current deployment will run into problems when using not vanilla geonode implementations. so make the helm chart aware of things like fixtures and so on is a plus. As geonode4.2 also targets a new init process for their django geonode container, this helm chart is open to initialize the deployment also apart from tasks.py.

But for now i think defining fixtures inside the values.yaml could add a function call inside of tasks.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new required feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants