New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevents Hot Loader from Refreshing Page #36
Comments
As far as I know, HMR deals only with reducers (if you enable it in your store) as you can use About the "JavaScript TypeError saying e is not a function" cannot reproduce it with the counter example. Could you share an example? BTW, it would be a great contribution to have here a simple ImmutableJS example to check it when we implement new features. |
Hey @garretto, Even though I cannot reproduce it, should be fixed in |
To be fair action creators should be reloaded if you use React Hot Loader. They don't with React Transform—we'll fix that eventually but not very soon. |
@zalmoxisus I tried with the new version and no dice. Something in the plugin prevents a full page reload. Also for editing reducers actually. Ended up just installing redux-dev-tools into my project and it works fine there. Also should have mentioned I'm using react-transform-hmre @gaearon not react-hot-loader. Thanks for creating both of those by the way. :) |
If I get some time I'll try to reproduce with the counter example. |
That's strange, just tried |
The {
"presets": ["react", "es2015"],
"env": {
"development": {
"presets": ["react-hmre"]
}
}
} Whereas the {
"presets": [ "es2015", "stage-0", "react" ],
"plugins": [ "add-module-exports", "transform-decorators-legacy" ]
} If you remove the Similarly, if you install |
@nirrek, thanks for the explanation. In the unbuilt (unuglified) extension I'm curious to see the case when the error occurs only with the extension enabled and especially looking forward to seeing how we can get actions hot reloaded. |
FYI we added an explicit error message in Redux 3.1.5 for this. |
@gaearon, unfortunately, this doesn't help in our case as |
Oh, good point. Want to make a PR? |
@gaearon, gladly :) |
Found another issue. I'm using react-transform-hmr and this extension prevents the page from refreshing if a full refresh is required. For example, if I change code in my action creators. Instead of refreshing, I get a JavaScript TypeError saying e is not a function. Then I have to refresh the page manually.
Any ideas? Thanks!
The text was updated successfully, but these errors were encountered: