Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13.6] Generic type 'StoreEnhancer' requires 1 type argument(s). #584

Closed
davydof opened this issue Nov 26, 2018 · 4 comments
Closed

[2.13.6] Generic type 'StoreEnhancer' requires 1 type argument(s). #584

davydof opened this issue Nov 26, 2018 · 4 comments

Comments

@davydof
Copy link

davydof commented Nov 26, 2018

redux-devtools-extension: 2.13.6

node_modules/redux-devtools-extension/index.d.ts:159:73 - error TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

159 export function composeWithDevTools<StoreExt, StateExt>(...funcs: Array<StoreEnhancer<StoreExt, StateExt>>): StoreEnhancer<StoreExt, StateExt>;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/redux-devtools-extension/index.d.ts:159:110 - error TS2314: Generic type 'StoreEnhancer' requires 1 type argument(s).

159 export function composeWithDevTools<StoreExt, StateExt>(...funcs: Array<StoreEnhancer<StoreExt, StateExt>>): StoreEnhancer<StoreExt, StateExt>;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

in redux-devtools-extension 2.13.5 all is fine

@zalmoxisus
Copy link
Owner

zalmoxisus commented Nov 26, 2018

It was introduced in #578. Maybe @scally knows what the issue is related to, as there were cases when we need that second argument.

@JPeer264
Copy link
Contributor

If the typings get changed to StoreEnhancer<StoreExt> instead of StoreEnhancer<StoreExt, StoreExt> (doubled types) it got fixed.

@davydof
Copy link
Author

davydof commented Nov 27, 2018

@JPeer264
yes, so it should be changed in redux-devtools-extension repo

@zalmoxisus
Copy link
Owner

I published 2.13.7, should be fixed now. Thanks @JPeer264 for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants