Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about side effects? #86

Closed
max-mykhailenko opened this issue Apr 3, 2016 · 3 comments
Closed

What about side effects? #86

max-mykhailenko opened this issue Apr 3, 2016 · 3 comments
Labels

Comments

@max-mykhailenko
Copy link

Maybe it's question not about extensions only. I can remove action in devtools, but I have side effect to browser hash and I can't imagine how I can revert url to the previous state. Maybe you have thoughts about it.
Thanks!

@zalmoxisus
Copy link
Owner

Thanks for opening this issue. It's something that concerns me as well, but it is not something that could be solved on the extension or monitors side (as per zalmoxisus/redux-devtools-filter-actions#3). A possible solution was suggested in reduxjs/redux-devtools#263.

I will keep this issue open for any ideas and suggestions.

@max-mykhailenko
Copy link
Author

@gaearon maybe we can log all side effects in redux and then downgrade them like database migrations?

@zalmoxisus
Copy link
Owner

Unfortunately, I don't see how we can handle it completely here. Side effects should be reverted by the middleware / function caused that. We'll not be able to downgrade them from the extension (as in your example to change the location hash back).

Not sure how universal the solution is, but in v2.7 we can lock the changes and dispatch the actions explicitely without having any side effects. More details in [the blog post](Redux DevTools Extension v2.7).

Feel free to reopen the issue if you have any ideas how to implement it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants