Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No animation without .ph-item #20

Closed
MickL opened this issue Jan 24, 2021 · 4 comments · Fixed by #22
Closed

No animation without .ph-item #20

MickL opened this issue Jan 24, 2021 · 4 comments · Fixed by #22

Comments

@MickL
Copy link
Contributor

MickL commented Jan 24, 2021

I would like to place just the elements (image placeholder, text placeholder) without the frame created by .ph-item. But if I do so no animation is running.

My suggestion would be:

  • Let everything work without the wrapper .ph-item, OR
  • Create a second class .ph-item-no-border or an additonal class .clean that removes border, margin and padding

I would prefer the first option so it is easy to place an image-placeholder for example without the need of a wrapper ph-item. On the other hand having a wrapper would allow for having centered content as described in #21

In addition the values of .ph-item (border, padding, margin) should be configurable through variables imo.

@MickL
Copy link
Contributor Author

MickL commented Jan 24, 2021

I made a PR where I added a .clean class along with some other small improvements.

@zalog
Copy link
Owner

zalog commented Jan 25, 2021

Great @MickL! Thanks for your time!
I like the issues that you came up with.
I'll get back to this as soon as possible.

@MickL
Copy link
Contributor Author

MickL commented Jan 28, 2021

@zalog Could you check my PR yet? :)

@zalog
Copy link
Owner

zalog commented Jan 28, 2021

Not yet, sorry :(
But I hope soon :)

@zalog zalog closed this as completed in #22 Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants