Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain ONNX Operators #401

Closed
ar-roy opened this issue Dec 5, 2023 · 2 comments
Closed

Certain ONNX Operators #401

ar-roy opened this issue Dec 5, 2023 · 2 comments

Comments

@ar-roy
Copy link

ar-roy commented Dec 5, 2023

Hi team, I've noticed that ONNX operators have been slowly added over previous releases this past year (kudos!).

There are two operators missing when attempting to convert a pretrained torch ResNet18 model via compile_torch_model:

  1. Expand
  2. ReduceL2

Are these two operators missing due to limitations on the FHE side or because they are not commonly used?
Thanks!

@fd0r
Copy link
Collaborator

fd0r commented Dec 6, 2023

Hello @ar-roy, thanks for your interest in Concrete ML!

These two operators are not supported at the moment because we didn't find a use for them yet but we will add them to our roadmap!

If you can't wait for us to implement them you can also add them yourselves and do a PR to this repository. If you want to do so I would advise you to start looking at our QuantizedOps objects in https://github.com/zama-ai/concrete-ml/blob/main/src/concrete/ml/quantization/quantized_ops.py

We'll ping you here once the feature is available in the latest release. 🙂

@ar-roy
Copy link
Author

ar-roy commented Dec 6, 2023

Thanks @fd0r!

I'll look into doing a PR if necessary or see if there is some work-around for the operations on my end.

I'll close this out for now, looking forward to new releases as they come! 👍

@ar-roy ar-roy closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants