Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate optimized modules manifest from compiler info #5

Closed
mstade opened this issue Jan 25, 2016 · 2 comments
Closed

Generate optimized modules manifest from compiler info #5

mstade opened this issue Jan 25, 2016 · 2 comments

Comments

@mstade
Copy link
Member

mstade commented Jan 25, 2016

Currently, we look to the file system to find which modules are generated, and thus what to put in optimised-modules.json. However, this should really be information coming from the compiler directly. Indeed, this information may change along the way particularly if a tree shaking linker is used prior to generating the output.

@mstade
Copy link
Member Author

mstade commented Feb 22, 2016

Actually, as it happens, all generated output has to be included in optimised-modules.json, since otherwise we won't get proper module resolution in runtime environments. I'm not sure whether this should just be lib/**/* – it'd certainly be the naive approach, and possibly the right one. Ping @zambezi/ui – thoughts?

@mstade
Copy link
Member Author

mstade commented Feb 23, 2016

This was resolved in #13.

@mstade mstade closed this as completed Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant