Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unitaryhack] add exponential wrapper class #28

Merged

Conversation

ixime
Copy link
Contributor

@ixime ixime commented Jun 12, 2022

Description

Implement a class exponential wrapper around the Gate Protocol.

Please verify that you have completed the following steps

  • I have self-reviewed my code.
  • I have included test cases validating introduced feature/fix.
  • I have updated documentation.

Copy link
Contributor

@AthenaCaesura AthenaCaesura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so so much for your contribution! This is great!
May I ask that you write some tests for this though? For both the new Exponential class and for serde. You can use this PR as a template for your tests.

@ixime
Copy link
Contributor Author

ixime commented Jun 13, 2022

Thanks so so much for your contribution! This is great! May I ask that you write some tests for this though? For both the new Exponential class and for serde. You can use this PR as a template for your tests.

Sure! I was in the middle of preparing them 😄

@mstechly
Copy link
Contributor

This solves zapata-engineering/orquestra-core#15

@codecov-commenter
Copy link

Codecov Report

Merging #28 (b13270f) into main (ca7fbe9) will increase coverage by 0.03%.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   94.29%   94.32%   +0.03%     
==========================================
  Files          68       68              
  Lines        5570     5621      +51     
==========================================
+ Hits         5252     5302      +50     
- Misses        318      319       +1     
Impacted Files Coverage Δ
src/orquestra/quantum/circuits/_gates.py 94.94% <97.77%> (+0.54%) ⬆️
src/orquestra/quantum/circuits/_serde.py 98.30% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7fbe9...b13270f. Read the comment docs.

Copy link
Contributor

@AthenaCaesura AthenaCaesura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for your contribution! Can I have your email so our legal department send you a CLA so that we can add your contribution to our codebase! If you don't want to post it here you can just email me at athena.ceasura@zapatacomputing.com and we'll get it to you.

Also, the T-shirt offer still stands. 😉

@ixime ixime changed the title [WIP] [unitaryhack] add exponential wrapper class [unitaryhack] add exponential wrapper class Jun 14, 2022
@ixime
Copy link
Contributor Author

ixime commented Jun 14, 2022

athena.ceasura@zapatacomputing.com

Hi @AthenaCaesura thanks for your message. I've just saw it! For some reason the emails I've just sent you were blocked, but I think @mstechly already have my email.
Please let me know if there is something more to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants