This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Various improvements #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original apply function had a catchall section where any unknown method_type would be applied as a filter. This change honours that catchall.
pull changes in
|
Wow, this is quite large. I'm not sure we have the time to manage this repo (internally we've kind of forked rather dramatically). Would you guys like commit access to merge this all in? |
|
(Also, a rebase would make it easier to get merged!) |
bryanhelmig
added a commit
that referenced
this pull request
Dec 10, 2014
bryanhelmig
added a commit
that referenced
this pull request
Dec 10, 2014
Various Improvements (A Continuation of #44)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forked budlights repository and then added the ability to use F expressions in field values.
Bud lights comments aren't very explanatory but he has made some worthwhile improvements.