Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity checks for controller assignments #58

Open
pahund opened this issue Dec 15, 2019 · 0 comments
Open

Add sanity checks for controller assignments #58

pahund opened this issue Dec 15, 2019 · 0 comments
Labels
enhancement Something should be improved
Projects

Comments

@pahund
Copy link
Collaborator

pahund commented Dec 15, 2019

In the track definition JSON file, a track def author may mistakenly assign the same controller for the same MIDI bus and channel to multiple channel elements or to playing.

In this case, multiple MIDI controller commands are sent to the same channel when the scene changes, causing unpredictable results.

Add a validation step that checks for mistakes of this kind and throws an error.

Another possible solution for this may be that in some cases, this is allowed, see issue #59.

@pahund pahund created this issue from a note in Zapperment (To do) Dec 15, 2019
@pahund pahund added the enhancement Something should be improved label Dec 15, 2019
@pahund pahund moved this from To do to Someday / Maybe in Zapperment Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something should be improved
Projects
Zapperment
  
Someday / Maybe
Development

No branches or pull requests

1 participant