Use Network add-on to manage connection options #7291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate `ConnectionParam` and remove its usage where possible, the network add-on will manage the connection options. Deprecate related classes and adjust the code to avoid deprecation warnings. Deprecate API connection endpoints. Remove test and file no longer needed. Signed-off-by: thc202 <thc202@gmail.com>
thc202
force-pushed
the
deprecate-connection-options
branch
from
36af8e9
to
469f531
Compare
thc202
added a commit
to thc202/zap-extensions
that referenced
this pull request
May 20, 2022
Manage the connection options, through the UI and API, when the core ones are deprecated. Related to zaproxy/zaproxy#7291. Signed-off-by: thc202 <thc202@gmail.com>
psiinon
approved these changes
May 20, 2022
thc202
changed the title
|
No longer WIP. |
kingthorin
approved these changes
May 20, 2022
thc202
added a commit
to thc202/zap-core-help
that referenced
this pull request
May 21, 2022
Remove the Connection options page, now provided by the Network add-on. Update other pages accordingly. Mention deprecated endpoints in the release notes. Part of zaproxy/zaproxy#7291. Signed-off-by: thc202 <thc202@gmail.com>
thc202
added a commit
to thc202/zap-core-help
that referenced
this pull request
May 21, 2022
Remove the Connection options page, now provided by the Network add-on. Update other pages accordingly. Mention deprecated endpoints in the release notes. Part of zaproxy/zaproxy#7291. Signed-off-by: thc202 <thc202@gmail.com>
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
ConnectionParamand remove its usage where possible, thenetwork add-on will manage the connection options.
Deprecate related classes and adjust the code to avoid deprecation
warnings.
Deprecate API connection endpoints.
Remove test and file no longer needed.
WIP pending changes in the add-on.