Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow icons to be scaled independently of the text #7326

Closed
psiinon opened this issue Jun 8, 2022 · 6 comments · Fixed by #7401
Closed

Allow icons to be scaled independently of the text #7326

psiinon opened this issue Jun 8, 2022 · 6 comments · Fixed by #7401
Assignees
Labels
Component-UI enhancement good second issue A non trivial issue but still one that is relatively straightforward. Usability
Milestone

Comments

@psiinon
Copy link
Member

psiinon commented Jun 8, 2022

As per #541 buttons are scaled when the default font is scaled.
Having an option to scale them independently would help some people.
I think keeping the current behaviour as the default would be best.

@thc202 thc202 changed the title Allow buttons to be scaled independantly of the text Allow buttons to be scaled independently of the text Jun 8, 2022
@thc202 thc202 changed the title Allow buttons to be scaled independently of the text Allow icons to be scaled independently of the text Jun 8, 2022
@psiinon
Copy link
Member Author

psiinon commented Jun 8, 2022

If anyone else fancies having a go at this then the key class is https://github.com/zaproxy/zaproxy/blob/main/zap/src/main/java/org/zaproxy/zap/utils/DisplayUtils.java - esp the getScaledIcon(..) methods.
The options will also need changing as well as the relevant dialog...

@psiinon psiinon added the good second issue A non trivial issue but still one that is relatively straightforward. label Jun 8, 2022
@Siddharth3330
Copy link
Contributor

Hi, I would like to work on it.

@psiinon
Copy link
Member Author

psiinon commented Jul 6, 2022

Great! Anything you would like help with?

@Siddharth3330
Copy link
Contributor

Siddharth3330 commented Jul 7, 2022

Hi, I believe I didn't understand the problem statement correctly.
When I tried scaling font size the icon size remains the same(if I uncheck Scale images option). So do we require a similar block like "General Font" to scale the icon size within this display option?
Screenshot (152)

@ricekot
Copy link
Member

ricekot commented Jul 7, 2022

We want to be able to change the size of the icons without changing the size of the text.
A new block for icons sounds reasonable to me.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component-UI enhancement good second issue A non trivial issue but still one that is relatively straightforward. Usability
Development

Successfully merging a pull request may close this issue.

4 participants