Use name of enum as default value for configs #8252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the name of the enum instead of the string representation otherwise it would fail to convert the string to enum when overridden, while the default value would still be used a warning would be logged. Signed-off-by: thc202 <thc202@gmail.com>
psiinon
approved these changes
Dec 18, 2023
kingthorin
approved these changes
Dec 18, 2023
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the name of the enum instead of the string representation otherwise it would fail to convert the string to enum when overridden, while the default value would still be used a warning would be logged.
From log shared in ZAP User Group: https://groups.google.com/g/zaproxy-users/c/oaR0MvG1BPQ/m/HSSFj9NQAwAJ