Improve logs related to loading of pscanrules #8274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Dec 28, 2023
zap/src/main/java/org/zaproxy/zap/extension/pscan/ExtensionPassiveScan.java
Outdated
Show resolved
Hide resolved
ricekot
force-pushed
the
pscan/install-logs
branch
from
e919466
to
fd2a0b4
Compare
kingthorin
approved these changes
Dec 29, 2023
ricekot
force-pushed
the
pscan/install-logs
branch
from
fd2a0b4
to
3e52f92
Compare
8 tasks
thc202
reviewed
Dec 29, 2023
zap/src/main/java/org/zaproxy/zap/extension/pscan/ExtensionPassiveScan.java
Show resolved
Hide resolved
zap/src/main/java/org/zaproxy/zap/extension/pscan/PassiveScannerList.java
Outdated
Show resolved
Hide resolved
Also, don't show the passive scan rule in the UI if it wasn't installed successfully. Signed-off-by: ricekot <github@ricekot.com>
ricekot
force-pushed
the
pscan/install-logs
branch
from
3e52f92
to
eb154e3
Compare
thc202
approved these changes
Dec 30, 2023
|
Thank you! |
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, don't show the passive scan rule in the UI if it wasn't installed
successfully.