Anti-CSRF Handling should always account for partial matching #8283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
force-pushed
the
csrf-partial
branch
from
daddb5a
to
cf86ab3
Compare
thc202
reviewed
Jan 4, 2024
zap/src/test/java/org/zaproxy/zap/extension/anticsrf/ExtensionAntiCSRFUnitTest.java
Outdated
Show resolved
Hide resolved
- ExtensionAntiCSRF - Ensure public method always accounts for partial matching. - ExtensionAntiCSRFUnitTest - Add a method to assert the behavior. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
csrf-partial
branch
from
cf86ab3
to
aecf7cc
Compare
|
Testing tweaked. |
|
Also I noticed one of the constants in the test class is misspelled, which I'm happy to correct here or another PR.
|
|
Fine here in a separate commit? |
|
Sure |
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
kingthorin
force-pushed
the
csrf-partial
branch
from
8d1a3e2
to
74eefb4
Compare
thc202
approved these changes
Jan 4, 2024
|
Thank you! |
psiinon
approved these changes
Jan 5, 2024
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: