Allow setting the log level via a CLI argument

[ricekot]

No description provided.

[kingthorin]

Related to: #4513

[kingthorin]

I don't see anything wrong with this. But I'm not clear on the implementation, is this using env var values? (ex: Where/how would the user set/override it?).

[ricekot]

These can be set by passing flags to the JVM, e.g.

java -Dzap.log.level=debug -jar ./zap-2.15.0-SNAPSHOT.jar

Maybe we should also update zap.sh to accept a flag and append this to the arguments it passes to the JVM.

[psiinon]

I think we should have a relatively easy documented way for users to set it, and if that means updating zap.sh (and zap.bat??) then we should do so.

[ricekot]

Updated as discussed in IRC - added a -loglevel flag that can be used to set the log level.

[psiinon]

-loglevel debug gives way more than usual, but I guess thats expected?
-loglevel bad is ignored - I expected that to fail with some message about an invalid logging level..

Other than that its looking good 😁

[ricekot]

-loglevel debug gives way more than usual

We could change it to only set the level for the ZAP classes, and leave the root log level as-is.

-loglevel bad is ignored - I expected that to fail with some message about an invalid logging level..

That was intentional. I thought a bad log level didn't warrant crashing ZAP, since we have a log level in the log4j2.properties file anyway, but I can tweak this.

[psiinon]

+1 for only setting the ZAP logging levels (others may disagree?)
We should at least give a warning/error on a bad level otherwise it might be hard for a user to debug a typo?
The help will say which log levels are supported?

[thc202]

Thank you!

[github-actions]

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.