Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context inclusion issues #8302

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix context inclusion issues #8302

merged 1 commit into from
Jan 31, 2024

Conversation

ricekot
Copy link
Member

@ricekot ricekot commented Jan 11, 2024

When a strict regex was used (e.g. when importing OpenAPI specs), there were issues with including or excluding endpoints from the context because of improper parsing of nodeNames. This included:

  • Endpoints with path params (Data Driven Nodes)
  • Endpoints with both query and form params

@thc202 thc202 added bug and removed Type-Task labels Jan 11, 2024
@thc202 thc202 added this to the 2.15.0 milestone Jan 11, 2024
@ricekot ricekot changed the title Fix issues related to including DDNs in context Fix context inclusion issues Jan 19, 2024
When a strict regex was used (e.g. when import OpenAPI specs), there
were issues with including or excluding endpoints from the context
because of improper parsing of nodeNames of:

* Endpoints with path params (Data Driven Nodes)
* Endpoints with both query and form params

Signed-off-by: ricekot <github@ricekot.com>
@kingthorin
Copy link
Member

I'm assuming @thc202 will want to review this as well.

@thc202
Copy link
Member

thc202 commented Jan 21, 2024

Yes.

@thc202 thc202 merged commit 3111e2a into zaproxy:main Jan 31, 2024
9 checks passed
@thc202
Copy link
Member

thc202 commented Jan 31, 2024

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@ricekot ricekot deleted the ddns-context branch January 31, 2024 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants