Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation of org.zaps166.QMPlay2.appdata.xml fails #92

Closed
martinkg opened this issue Mar 18, 2017 · 3 comments
Closed

validation of org.zaps166.QMPlay2.appdata.xml fails #92

martinkg opened this issue Mar 18, 2017 · 3 comments
Labels

Comments

@martinkg
Copy link
Contributor

appstream-util validate-relax --nonet /usr/share/appdata/qmplay2.appdata.xml FAILED:
? tag-missing           : <metadata_license> is not present
? tag-invalid           : <icon> not allowed in desktop appdata
? tag-invalid           : stock icon is not valid [QMPlay2]
Validation of files failed

patch to fix this: fix_QMPlay2-appdata-xml.patch

--- QMPlay2-src-17.03.17.orig/src/gui/Unix/QMPlay2.appdata.xml.in	2017-03-11 01:19:26.000000000 +0100
+++ QMPlay2-src-17.03.17/src/gui/Unix/QMPlay2.appdata.xml.in	2017-03-18 12:14:45.091071846 +0100
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <component type="desktop-application">
-    <id>org.zaps166.QMPlay2</id>
+    <id>QMPlay2.desktop</id>
+    <metadata_license>CC0-1.0</metadata_license>
     <name>QMPlay2</name>
     <summary>Video and audio player</summary>
     <description>
@@ -11,7 +12,6 @@
     </description>
     <url type="homepage">http://zaps166.sourceforge.net/?app=QMPlay2</url>
     <url type="bugtracker">https://github.com/zaps166/QMPlay2/issues</url>
-    <icon type="stock">QMPlay2</icon>
     <categories>
         <category>AudioVideo</category>
         <category>Player</category>
@zaps166
Copy link
Owner

zaps166 commented Mar 18, 2017

Ok, thanks. But what about the installed file name? Should be "QMPlay2.appdata.xml" or "org.zaps166.QMPlay2.appdata.xml"?

@zaps166 zaps166 added the bug label Mar 18, 2017
@martinkg
Copy link
Contributor Author

the name should be QMPlay2.appdata.xml

@zaps166
Copy link
Owner

zaps166 commented Mar 18, 2017

Ok, fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants