Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml #364

Closed
jakirkham opened this issue Oct 17, 2022 · 7 comments · Fixed by #382
Closed

Move to pyproject.toml #364

jakirkham opened this issue Oct 17, 2022 · 7 comments · Fixed by #382

Comments

@jakirkham
Copy link
Member

It would be good to move to pyproject.toml in Numcodecs. In particular it would be nice to add build requirements (like Cython) and setup_requires to pyproject.toml.

This should also allow us to do things like dropped the vendored C files, which cause us some pain periodically ( #358 (comment) ). Plus drop some of the complexity in setup.py.

FWIW this was done for Zarr in PR ( zarr-developers/zarr-python#1158 ).

@jakirkham
Copy link
Member Author

cc @Saransh-cpp @joshmoore

@Saransh-cpp
Copy link
Contributor

This might get a bit tricky because of the Cython code. I'll try to look into this!

@jakirkham
Copy link
Member Author

Yep that's definitely true. Even an incremental move or moving most things over would be a welcome improvement 🙂

@joshmoore
Copy link
Member

Thanks, @Saransh-cpp. 🙏🏽

@jakirkham
Copy link
Member Author

We have the beginnings of a pyproject.toml with PR ( #369 ). Though more work in this area would be welcome 🙂

cc @DimitriPapadopoulos (in case this is of interest as well)

@jakirkham
Copy link
Member Author

Submitted PR ( #382 ), which moves as much as we can to pyproject.toml. Not sure if there is anything else we can move (though feedback on that would be welcome). Also am familiarizing myself with the process so may well have missed things that others will catch.

@jakirkham
Copy link
Member Author

There may be small follow up things that come up. Would suggest raising them in new issues. Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants